-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
descheduler: fix bug of nodeAnomalyDetector in LowNodeLoad plugin #1858
Conversation
fix #1854 Signed-off-by: bogo <70442600+bogo-y@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1858 +/- ##
==========================================
- Coverage 67.25% 67.24% -0.01%
==========================================
Files 407 407
Lines 45650 45650
==========================================
- Hits 30703 30699 -4
- Misses 12731 12738 +7
+ Partials 2216 2213 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eahydra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…ordinator-sh#1858) Signed-off-by: bogo <70442600+bogo-y@users.noreply.github.com>
…ordinator-sh#1858) Signed-off-by: bogo <70442600+bogo-y@users.noreply.github.com>
…ordinator-sh#1858) Signed-off-by: bogo <70442600+bogo-y@users.noreply.github.com>
…ordinator-sh#1858) Signed-off-by: bogo <70442600+bogo-y@users.noreply.github.com>
…ordinator-sh#1858) Signed-off-by: bogo <70442600+bogo-y@users.noreply.github.com>
fix #1854
We should not try to mark all source nodes as normal because only abnormal nodes have been evicted. This PR changes it so that only abnormal nodes will be marked as normal.
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test